-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two more gallery examples #274
Conversation
nvaytet
commented
Oct 24, 2023
- Interactive masking from drawing rectangles on a 2d data
- Two scatter point clouds on the same scene with different opacities
@@ -220,20 +220,18 @@ | |||
# -- Options for nbsphinx gallery------------------------------------------ | |||
notebook_root = 'gallery' | |||
thumbnail_root = os.path.join('_static', 'gallery') | |||
gallery_notebooks = [ | |||
'nyc-taxi', | |||
'masking-a-range', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbnail missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notebooks have their thumbnail auto-generated (the ones that are making 2d plots)
"source": [ | ||
"# Interactive masking\n", | ||
"\n", | ||
"In this example, we will use a custom drawing tool to draw rectangles on a 2D figure.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mention that this uses mpltoolbox already here because it is needed in the next cell.
Also, this requires the mpl backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the import of mpltoolbox
below, as it was unused.
I am now only importing lower down.
docs/gallery/peeling-layers.ipynb
Outdated
"tags": [] | ||
}, | ||
"source": [ | ||
"We select high-value and low-value two data ranges,\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this sentence. Typo?